report: make red/orange/green score color thresholds tougher #5831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Aug 14, 2018
| @@ -83,10 +83,10 @@ describe('util helpers', () => { | |||
| it('calculates a score ratings', () => { | |||
| assert.equal(Util.calculateRating(0.0), 'fail'); | |||
| assert.equal(Util.calculateRating(0.10), 'fail'); | |||
| assert.equal(Util.calculateRating(0.45), 'average'); | |||
| assert.equal(Util.calculateRating(0.45), 'fail'); | |||
| assert.equal(Util.calculateRating(0.55), 'average'); | |||
There was a problem hiding this comment.
can you add/tweak the test cases so we have coverage for 0.50 and .90
patrickhulce
approved these changes
Aug 14, 2018
| @@ -20,11 +20,11 @@ | |||
|
|
|||
| const ELLIPSIS = '\u2026'; | |||
| const NBSP = '\xa0'; | |||
| const PASS_THRESHOLD = 0.75; | |||
| const PASS_THRESHOLD = 0.9; | |||
|
Looks like the score legend needs updating as well? |
|
@paulirish no problem. We're already running 3.1 on SpeedCurve and noticed scores weren't aligned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For harmony with PSI thresholds.
note that
Util.PASS_THRESHOLDalso affects whentitlevsfailureTitleis selected for an audit@paulirish