Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(metrics): display metrics in seconds #5914

Merged
merged 5 commits into from
Aug 28, 2018
Merged

Conversation

patrickhulce
Copy link
Collaborator

Summary
Show non-EIL metrics in seconds. Also updates the two mainthread breakdown/bootup time audits to use seconds as well. Example screenshots of how it looks.

screen shot 2018-08-27 at 1 56 23 pm

screen shot 2018-08-27 at 3 23 56 pm

screen shot 2018-08-27 at 1 58 28 pm

Related Issues/PRs
fixes #5889

@addyosmani
Copy link
Member

Much prefer these being in seconds 👍

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickhulce patrickhulce merged commit f21b9ef into master Aug 28, 2018
@patrickhulce patrickhulce deleted the metrics_in_s branch August 28, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report: display metrics values in seconds
4 participants