report(util): ✅ audits should be in Passed Audits #5963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-category render tests
justinribeiro
changed the title
paulirish
reviewed
Sep 5, 2018
| @@ -140,7 +142,7 @@ describe('PerfCategoryRenderer', () => { | |||
| const diagnosticSection = categoryDOM.querySelectorAll('.lh-category > .lh-audit-group')[2]; | |||
|
|
|||
| const diagnosticAudits = category.auditRefs.filter(audit => audit.group === 'diagnostics' && | |||
| audit.result.score !== 1 && audit.result.scoreDisplayMode !== 'not-applicable'); | |||
| audit.result.score < PASS_THRESHOLD && audit.result.scoreDisplayMode !== 'not-applicable'); | |||
There was a problem hiding this comment.
can just use Util.PASS_THRESHOLD instead of the local declaration above.
i think that'll be fine despite all the jsdom beforeEach bs. but holler if its stupid.
brendankenny
reviewed
Sep 7, 2018
| @@ -140,7 +140,8 @@ describe('PerfCategoryRenderer', () => { | |||
| const diagnosticSection = categoryDOM.querySelectorAll('.lh-category > .lh-audit-group')[2]; | |||
|
|
|||
| const diagnosticAudits = category.auditRefs.filter(audit => audit.group === 'diagnostics' && | |||
| audit.result.score !== 1 && audit.result.scoreDisplayMode !== 'not-applicable'); | |||
| audit.result.score < Util.PASS_THRESHOLD && | |||
There was a problem hiding this comment.
@paulirish was there a historical reason for this not just being !Util.showAsPassed(audit.result)?
There was a problem hiding this comment.
👍 Sorted in 6a1715a.
brendankenny
reviewed
Sep 8, 2018
| @@ -140,7 +140,8 @@ describe('PerfCategoryRenderer', () => { | |||
| const diagnosticSection = categoryDOM.querySelectorAll('.lh-category > .lh-audit-group')[2]; | |||
|
|
|||
| const diagnosticAudits = category.auditRefs.filter(audit => audit.group === 'diagnostics' && | |||
| audit.result.score !== 1 && audit.result.scoreDisplayMode !== 'not-applicable'); | |||
| !Util.showAsPassed(audit.result) && | |||
| audit.result.scoreDisplayMode !== 'not-applicable'); | |||
There was a problem hiding this comment.
oh, sorry, should have put the comment below this line. showAsPassed() includes the not-applicable check :)
There was a problem hiding this comment.
That's my bad; I should have noticed the check showAsPassed. 👍 Fixed in latest commit.
paulirish
approved these changes
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Util.showAsPassed()now default compares toRATINGS.PASS.minScore; updated the perf-category render tests to check against the addedPASS_THRESHOLDconst. Resolves #5959With PR
Without PR
