Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(screenshot-thumbnails): improve caching #5976

Merged
merged 2 commits into from
Sep 6, 2018
Merged

core(screenshot-thumbnails): improve caching #5976

merged 2 commits into from
Sep 6, 2018

Conversation

midzer
Copy link
Contributor

@midzer midzer commented Sep 6, 2018

Summary

Improve caching logic for already existing thumbnail data to skip unnecessary (expensive) function calls

Should result in better performance on complete LH run. Did not measure though :|

More performance without overengineering is a good thing :)

Related Issues/PRs

#5957

@midzer midzer changed the title improve logic for thumbnail caching core(screenshot-thumbnails): improve caching Sep 6, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for the fix!

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried measuring this (quickly). Nothin too substantial, but it may be going from 230ms to 215ms on my test trace. Heh, so not as much of a win as we expected.

oh well, the code looks a lot better now. :)

@paulirish paulirish merged commit fa20953 into GoogleChrome:master Sep 6, 2018
@midzer midzer deleted the improveThumbnailCaching branch September 6, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants