core(driver): deliver trace as events rather than a stream #6056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
commented
Sep 19, 2018
paulirish
requested changes
Sep 19, 2018
brendankenny
requested changes
Sep 19, 2018
3 tasks
paulirish
approved these changes
Sep 19, 2018
lighthouse-core/gather/driver.js
Outdated
|
|
||
| // Issue the command to stop tracing. | ||
| return this.sendCommand('Tracing.end').catch(reject); | ||
| // setup listener for when a trace bundle is sent |
There was a problem hiding this comment.
"trace chunk" but yeah. How about "// dataCollected events fire for each trace chunk, in order"
There was a problem hiding this comment.
Changed, see if u like it.
|
|
||
| return this.sendCommand('IO.read', readArguments).then(onChunkRead); | ||
| }; | ||
| this.once('Tracing.tracingComplete', _ => { |
There was a problem hiding this comment.
so. much. easier. :D
paulirish
changed the title
This was referenced Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the Tracing.start protocol command to use the
ReportEventstransferMode instead ofReturnAsStream. This makes the trace gathering much faster, as observed in some automated run timings:Note: timings are averages of 5 seperate runs with each method.
Related Issues/PRs
fixes #5968
closes #5939
Based on code in old driver implementation