Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: tweaks for devtools client #6127

Merged
merged 2 commits into from
Sep 27, 2018
Merged

misc: tweaks for devtools client #6127

merged 2 commits into from
Sep 27, 2018

Conversation

paulirish
Copy link
Member

  1. match score scale order to LS. (green, orange, red)
  2. negative margin of metrics is now scaled against circle-size, which is the intent.
  3. expose lh-background methods appropriately in a worker

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, are you seeing the same runLighthouseInExtension is not defined error that's in travis when you run yarn test-extension? I wouldn't think it would be affected by that change to lighthouse-background.js

@brendankenny
Copy link
Member

brendankenny commented Sep 27, 2018

ok, yes, I see the error locally too

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulirish paulirish merged commit df9481c into master Sep 27, 2018
@paulirish paulirish deleted the dtrolltweaks branch September 27, 2018 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants