Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(emulation): set desktop viewport to 1350x940 #6131

Merged
merged 1 commit into from
Sep 28, 2018
Merged

core(emulation): set desktop viewport to 1350x940 #6131

merged 1 commit into from
Sep 28, 2018

Conversation

paulirish
Copy link
Member

data i guess:

image

(this number is only used when emulatedFormFactor: 'desktop' which is mostly for headless scenarios.)

patrickhulce
patrickhulce approved these changes Sep 28, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what monitors come with this resolution, but looks desktop-y to me! 😆

brendankenny
brendankenny approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖼 💁🔝

@paulirish paulirish merged commit 69d328d into master Sep 28, 2018
@paulirish paulirish deleted the desktopy branch September 28, 2018 20:28
paulirish added a commit that referenced this pull request Oct 1, 2018
@paulirish
core(emulation): set desktop viewport to 1350x940 (#6131)
ab9567f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulirish @brendankenny @patrickhulce