core(computed): fix new computed artifact interface #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
approved these changes
Oct 1, 2018
| @@ -71,7 +71,7 @@ describe('ManifestValues computed artifact', () => { | |||
| const Manifest = noUrlManifestParser(JSON.stringify({ | |||
| start_url: '/', | |||
| })); | |||
| const results = await ManifestValues.request(getMockContext(), Manifest); | |||
| const results = await ManifestValues.request(Manifest, getMockContext()); | |||
There was a problem hiding this comment.
Why does the naming change from manifestArtifact to Manifest halfway through? Are they different later than in the beginning?
There was a problem hiding this comment.
Are they different later than in the beginning?
no, just different original authors/written at different times in the code base, I assume
patrickhulce
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5907 didn't quite work because computed artifacts need to call each other, so need access to the
contextto pass it on to the next computed artifact :)Since that's now explicit, flipped the order of the parameters so it's
compute_(inputArtifacts, context), which matches the interface foraudit.audit()(not sure why I did it the other way before). About 3/4 of this PR is flipping the order formanifest-valuesfrom #5907.Also updated
screenshots.jsto this new format.