Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(critical-request-chain): remove empty children from LHR #6211

Merged
merged 3 commits into from Oct 11, 2018
Merged

core(critical-request-chain): remove empty children from LHR #6211

merged 3 commits into from Oct 11, 2018

Conversation

exterkamp
Copy link
Member

Summary
Removes empty children object from the crc details LHR. This will allow the proto struct to parse the crc details object 1:1.

Related Issues/PRs
#6183

@exterkamp
Copy link
Member Author

type-check is complaining about some stuff in firebase-auth?

app/src/firebase-auth.js:72:27 - error TS2531: Object is possibly 'null'.

72       const accessToken = result.credential.accessToken;
                             ~~~~~~~~~~~~~~~~~

app/src/firebase-auth.js:72:45 - error TS2339: Property 'accessToken' does not exist on type 'AuthCredential'.

72       const accessToken = result.credential.accessToken;

brendankenny
brendankenny reviewed Oct 11, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type-check is complaining about some stuff in firebase-auth?

you might need to yarn? not seeing this in Travis and no reason the change in this PR should cause this

@exterkamp
Copy link
Member Author

Needed to restart my TS 🤣

patrickhulce
patrickhulce approved these changes Oct 11, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

paulirish
paulirish approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nit

lighthouse-core/audits/critical-request-chains.js Outdated Show resolved Hide resolved
brendankenny
brendankenny approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM3!

@brendankenny brendankenny merged commit 09cc741 into master Oct 11, 2018
@brendankenny brendankenny deleted the remove-crc-children branch October 11, 2018 18:29
@paulirish paulirish mentioned this pull request Oct 15, 2018
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@exterkamp @paulirish @brendankenny @patrickhulce