Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension: stop report bug prompt for file:// urls #6278

Merged
merged 1 commit into from
Oct 15, 2018
Merged

extension: stop report bug prompt for file:// urls #6278

merged 1 commit into from
Oct 15, 2018

Conversation

patrickhulce
Copy link
Collaborator

Summary
I think someone's already mentioned this but we don't need to prompt folks to file bugs for this one.

image

brendankenny
brendankenny approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically we allow chrome:// but that may just be confusing to call out here

someone want to update the audits panel as well? :)

@patrickhulce
Copy link
Collaborator Author

someone want to update the audits panel as well? :)

audits panel should already be handling this properly :)
https://cs.chromium.org/chromium/src/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js?q=PageAuditabilityChanged+-f:out&dr=CSs&l=99

@paulirish paulirish merged commit 2b12fc2 into master Oct 15, 2018
@paulirish paulirish deleted the extension_prevent_url branch October 15, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrickhulce @paulirish @brendankenny