core(audits): clarify diff between load-fast-enough-for-pwa's TTI and perf TTI #6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes this is intentional.
When using |
exterkamp
force-pushed
the
bug/TTI-diff
branch
from
d8b7b1a
to
31a2639
Compare
|
@patrickhulce modified this to have branching text for when the TTI is overridden. |
exterkamp
commented
Oct 16, 2018
patrickhulce
approved these changes
Oct 16, 2018
brendankenny
changed the title
patrickhulce
suggested changes
Oct 17, 2018
|
@exterkamp I know you have a lot on your plate, but do you want to take another look? |
exterkamp
changed the title
patrickhulce
approved these changes
Oct 23, 2018
| const override = context.settings.throttlingMethod === 'provided' || | ||
| !isDeepEqual(context.settings.throttling, mobileThrottling); | ||
|
|
||
| const displayValueFinal = override?displayValueTextWithOverride: displayValueText; |
|
|
||
| const displayValueFinal = override?displayValueTextWithOverride: displayValueText; | ||
|
|
||
| const settings = override ? Object.assign({}, context.settings, settingOverrides): |
There was a problem hiding this comment.
nit: spacing before : :)
There was a problem hiding this comment.
heh, updated linting is failing travis on this now :P
brendankenny
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In load-fast-enough-for-PWA the interactive when "provided" + mobile throttling is defaulted to force a simulated TTI, not the provided TTI (as shown in the top as the true TTI). @brendankenny remembers this being purposeful, but it does make inconsistent numbers. @patrickhulce do you have some context?Instead, will provide clearer explanation for why the TTIs might be different.
TODO:
If we do want to revert to this pass through of settings we need to update a test in
lighthouse-core/test/audits/load-fast-enough-for-pwa-test.jsRelated Issues/PRs
fixes: #6284