misc: simplify proto npm scripts #6406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Oct 26, 2018
| @@ -61,14 +61,13 @@ | |||
| "i18n:checks": "./lighthouse-core/scripts/i18n/assert-strings-collected.sh", | |||
| "i18n:collect-strings": "node lighthouse-core/scripts/i18n/collect-strings.js", | |||
| "update:sample-artifacts": "node lighthouse-core/scripts/update-report-fixtures.js -G", | |||
| "update:sample-json": "yarn i18n:collect-strings && node ./lighthouse-cli -A=./lighthouse-core/test/results/artifacts --throttling-method=devtools --output=json --output-path=./lighthouse-core/test/results/sample_v2.json && node lighthouse-core/scripts/cleanup-LHR-for-diff.js ./lighthouse-core/test/results/sample_v2.json --only-remove-timing", | |||
| "update:sample-json": "yarn i18n:collect-strings && node ./lighthouse-cli -A=./lighthouse-core/test/results/artifacts --throttling-method=devtools --output=json --output-path=./lighthouse-core/test/results/sample_v2.json && node lighthouse-core/scripts/cleanup-LHR-for-diff.js ./lighthouse-core/test/results/sample_v2.json --only-remove-timing && yarn compile-proto && yarn build-proto-roundtrip", | |||
There was a problem hiding this comment.
that's quite the line these days 😆
just thinking out loud below 💭
I guess the contributor thinking here is that if they already had to run update:sample-json then they would've failed the build without compile-proto so forcing protobuf in the path of this command isn't really a barrier. If they just needed string collection that would still run before all this junk failed anyhow. 👍
There was a problem hiding this comment.
^ yes. any meaningful changes require running both.
separately, can we bikeshed the script name?? :) how about update:goldens?
paulirish
approved these changes
Oct 26, 2018
| @@ -61,14 +61,13 @@ | |||
| "i18n:checks": "./lighthouse-core/scripts/i18n/assert-strings-collected.sh", | |||
| "i18n:collect-strings": "node lighthouse-core/scripts/i18n/collect-strings.js", | |||
| "update:sample-artifacts": "node lighthouse-core/scripts/update-report-fixtures.js -G", | |||
| "update:sample-json": "yarn i18n:collect-strings && node ./lighthouse-cli -A=./lighthouse-core/test/results/artifacts --throttling-method=devtools --output=json --output-path=./lighthouse-core/test/results/sample_v2.json && node lighthouse-core/scripts/cleanup-LHR-for-diff.js ./lighthouse-core/test/results/sample_v2.json --only-remove-timing", | |||
| "update:sample-json": "yarn i18n:collect-strings && node ./lighthouse-cli -A=./lighthouse-core/test/results/artifacts --throttling-method=devtools --output=json --output-path=./lighthouse-core/test/results/sample_v2.json && node lighthouse-core/scripts/cleanup-LHR-for-diff.js ./lighthouse-core/test/results/sample_v2.json --only-remove-timing && yarn compile-proto && yarn build-proto-roundtrip", | |||
There was a problem hiding this comment.
^ yes. any meaningful changes require running both.
separately, can we bikeshed the script name?? :) how about update:goldens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds proto roundtrip update to
yarn update:sample-jsonand updatesbuild-prototobuild-proto-roundtrip(this is (1) and (2) of #6405)