Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(jsdom): upgrade jsdom to support Element.prototype.closest #6411

Merged
merged 5 commits into from
Oct 30, 2018
Merged

core(jsdom): upgrade jsdom to support Element.prototype.closest #6411

merged 5 commits into from
Oct 30, 2018

Conversation

wardpeet
Copy link
Collaborator

Summary

Upgrade jsdom

Related Issues/PRs

@wardpeet wardpeet changed the title core(jsdom): upgrade jsdom to support closest core(jsdom): upgrade jsdom to support Element.prototype.closest Oct 26, 2018
@wardpeet wardpeet mentioned this pull request Oct 26, 2018
Merged
brendankenny
brendankenny reviewed Oct 26, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! seems to work just fine

Also have some lint errors

yarn.lock Outdated Show resolved Hide resolved
lighthouse-viewer/test/test-helpers.js Show resolved Hide resolved
brendankenny
brendankenny reviewed Oct 30, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn still an issue :) I think you need to be at something like yarn 1.10 to get the integrity hashes

@wardpeet
Copy link
Collaborator Author

ah i'm on yarn 1.7.0

@wardpeet
Copy link
Collaborator Author

@brendankenny this one should be ok now! 👌

brendankenny
brendankenny approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brendankenny brendankenny merged commit d0a2a52 into master Oct 30, 2018
@brendankenny brendankenny deleted the core/update-jsdom branch October 30, 2018 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@ebidel ebidel Awaiting requested review from ebidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wardpeet @brendankenny