Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(lib): add chrome-extension to URL allowedProtocols and add test #6447

Merged
merged 1 commit into from Nov 1, 2018

Conversation

justinribeiro
Copy link
Contributor

Resolves #6421.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think auditing chrome extensions from the Chrome extension still won't work, but it'd be too much of a pain IMO to thread that environment bit down of DT vs. extension here. LGTM!

@paulirish paulirish merged commit 5b0105f into GoogleChrome:master Nov 1, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, agreed. We need to fix the extension offering to auto-open a github issue on INVALID_URL anyways, so we can fix the problem then if it starts popping up through a different exception path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants