Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: rename core/gather/computed/ to core/computed/ #6618

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Nov 20, 2018

part of #6202

Also fixes a couple things:

  • log timing was added at the same time that core: convert computed artifact loading to regular require() #6204 updated computed artifacts, so timing info hasn't actually been collected for computed artifacts (timing was still accounted for in the audits that called them, though). This PR adds timing to the new version.

  • core: convert computed artifact loading to regular require() #6204 messed up and was using strict equality testing for the computed artifact cache, not deep equality. Computed artifacts that take a bare artifact (e.g. trace-of-tab) had no issue with this and cached correctly. Any computed artifact that take a more complicated input (e.g. all the metrics) always found keys to be unequal, and so reran their computations every time they were called. This was especially bad in the lantern metrics, which tend to call each other a lot and benefit a good deal from caching.

    This PR defaults ArbitraryEqualityMap to using deep equality now (since that's the only way we use it), and the kind of goofball test updated in computed-artifact-test.js proved it's worth and will prevent this from regressing again.

Good news: runs should speed up :)

Everything else is path updates.

@brendankenny
Copy link
Member Author

ok, we're going to split the PR, functional changes to follow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants