core(minification): properly handle regex character classes #6745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Dec 7, 2018
| } else if (char === '[') { | ||
| // Register that we're entering a character class so we don't leave the regex prematurely | ||
| isInRegexCharacterClass = true; | ||
| } else if (char === ']') { |
There was a problem hiding this comment.
should the condition also check that isInRegexCharacterClass is true?
There was a problem hiding this comment.
shouldn't affect the execution but it's definitely a lot more clear :) 👍 done
|
Two tangential things:
|
sigh 😞, I don't think we'll ever nail all the edge cases. I'm thinking we might want to do a second gut check of, "Hey if it thinks there's a crazy amount of savings when there's like no whitespace in this file, we should just ignore it's result"
😆 hahaha it totally did |
exterkamp
requested changes
Dec 7, 2018
…lighthouse into fix_minification_estimator
exterkamp
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The minification estimator heuristics weren't accounting for regex character classes properly which meant that it could leave a regex prematurely.
Related Issues/PRs
fixes #6744