i18n: localize audit error strings

[exterkamp]

Summary
Audit errors were adding the message code to the end of the errorMessage with parens which was destroying the ICU replacement. This adds defaultProperties to easier facilitate mutliple LHErrors using the same UIString to replace and use their own defaults that are constant per error.

Related Issues/PRs
fixes: #6804

[patrickhulce]

so what errors do we start losing for the code for after this, just the speedline ones? or the page load ones too?

I agree there's not a strong need for our users to know the code, but having it somewhere in the LHR would be nice.

[exterkamp]

I think we should follow the same pattern of splitting the speedline ones out into unique values.

[paulirish]

Nevermind all that. Let's do separate messages for these errors. :)

[exterkamp]

Okay, flip flopped again. I was about to split out all the speedline UIStrings, and then noticed all the pageLoadTookTooLong UIStrings which would also need to be split up afaik. So this seemed like it was getting ridiculous, so @brendankenny and I came to the compromise of providing the code of the Error to the ICU replacement by default, this seems to make sense since the code is always enumerated, and is all the replacements needed anyway at this point.

Thoughts?

[paulirish]

sgtm

[brendankenny]

LGTM!

Two last nits. The comment one probably wouldn't be worth another edit round on its own, but we probably should have the parens actually as parens in the test regex.