core(lhr): include resourceSize in network-requests audit

[paulirish]

along with the idea of #7052.... i noticed resource size isn't exposed in the lhr anywhere. seems reasonable to tack on here. wdyt?

[connorjclark]

isn't this bytes?

[patrickhulce]

yeah it is, i18n lib converts it I believe

lighthouse/lighthouse-core/lib/i18n/i18n.js

Lines 130 to 134 in f4b1635

	// Replace all the bytes with KB
	parsed.elements
	.filter(el => el.format && el.format.style === 'bytes')
	// @ts-ignore - el.id is always defined when el.format is defined
	.forEach(el => (clonedValues[el.id] = clonedValues[el.id] / 1024));

[brendankenny]

yeah, it's interpreted by the itemType but is put into the LHR as the displayUnit

[brendankenny]

but is put into the LHR as the displayUnit

er, that's not right. It is if it's in an i18ned string, otherwise it's not until details-renderer.js that the displayUnit is used...which is pointless here because these aren't displayed in the html report

[brendankenny]

LGTM

[brendankenny]

yeah, it's interpreted by the itemType but is put into the LHR as the displayUnit

[brendankenny]

why do these 0 resourceSize items have transferSize set?

[brendankenny]

why do these 0 resourceSize items have transferSize set?

and this makes a lot more sense now when 139 isn't the transferSize in KB, it's in bytes :)