core(renderer): do not attempt fireworks for devtools #7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Jan 24, 2019
| this._dom.find('.lh-header', headerContainer).addEventListener('click', _ => { | ||
| headerContainer.classList.toggle('fireworks-paused'); | ||
| }); | ||
| if (!this._dom.isDevTools()) { |
There was a problem hiding this comment.
is this a pavel-reaction undoing? 😆
or do we just not want to deal with the differences right now getting it to work in a smaller header?
There was a problem hiding this comment.
we are brushing up on the release deadline for next chrome, so quick is good, and I just wanted to toss in the same hotfix here. but also we don't even have a design for fireworks in DT. @exterkamp should totes look into that
exterkamp
approved these changes
Jan 24, 2019
| this._dom.find('.lh-header', headerContainer).addEventListener('click', _ => { | ||
| headerContainer.classList.toggle('fireworks-paused'); | ||
| }); | ||
| if (!this._dom.isDevTools()) { |
There was a problem hiding this comment.
I like this more simply as
if (!this._dom.isDevTools() && scoresAll100) {to be more flat, but it wfm either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a hotfix applied to the 4.0.0 devtools roll. Now adding here.