core(fcp-3g): remove unused i18n for LR compatibility #7103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
requested review from
paulirish,
brendankenny,
patrickhulce and
connorjclark
There was a problem hiding this comment.
I had thought browserify would just do the right thing here :/
yeah, weird that __filename gets resolved without complaint and brfs will handle require.resolve if nested inside a fs.readFileSync() call, but just a plain old require.resolve won't be taken care of.
The strings aren't used in the UI AFAIK. Do we even need to i18n them?
@paulirish is probably the only one to answer this as he seems to be the only one who really knows how this audit is being used :)
|
We don't need to i18n them. This will only be pulled programmatically. Similar to metrics and screenshot-thumbnails which don't get i18n'd. So we can just leave them unadorned as well. |
exterkamp
commented
Jan 29, 2019
paulirish
approved these changes
Jan 29, 2019
brendankenny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Drop the
require.resolveto find the i18n strings in exchange for an inlinedUIStringsso that browserify can find them and the audit can be run in Lightrider.