core(driver): add ' Chrome-Lighthouse' to useragent #7297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exterkamp
changed the title
exterkamp
changed the title
patrickhulce
approved these changes
Feb 25, 2019
| @@ -40,12 +40,12 @@ const DESKTOP_EMULATION_METRICS = { | |||
|
|
|||
| const NEXUS5X_USERAGENT = { | |||
| // eslint-disable-next-line max-len | |||
| userAgent: 'Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3694.0 Mobile Safari/537.36', | |||
| userAgent: 'Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3694.0 Mobile Safari/537.36 Chrome-Lighthouse', | |||
There was a problem hiding this comment.
so just sticking Chrome-Lighthouse on the end is what PSI currently does? 😮
well TIL
paulirish
changed the title
paulirish
approved these changes
Feb 25, 2019
brendankenny
approved these changes
Feb 25, 2019
SURE! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds 'Chrome-Lighthouse' to the UA for mobile and desktop so that Lighthouse and PSI have strongly consistent UAs.
Will come to PSI and web.dev on next update.
Related Issues/PRs
addresses: #7140