core(tap targets): make tap targets failures more visible #7373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattzeunert
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
mattzeunert
changed the title
patrickhulce
approved these changes
Mar 5, 2019
| passingTapTargetRatio = (passingTapTargetCount / tapTargetCount); | ||
| // If there are any failures then we don't want the audit to pass, | ||
| // so keep the score below 90. | ||
| score = Math.min(passingTapTargetRatio * 0.9, 0.89); |
There was a problem hiding this comment.
do we need to do both? isn't just doing 1 of these sufficient?
There was a problem hiding this comment.
Yeah just * 0.89 is enough.
I was trying to interpret this and thought maybe you meant that multiplying by 0.9 gives a smoother score or something.
I'd say go with
* .9/Math.min(score, .89)/targets.length ? 0 : 1if each and every failure should be looked at.
There was a problem hiding this comment.
oh yeah was just trying to suggest using one of those not in combination :)
There was a problem hiding this comment.
Ahh, it makes sense now 🙂
exterkamp
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Right now if the audit score is above 90 the tap targets audit doesn't fail even if there are overlap failures. That way it's hard to identify what's dragging the SEO score down. So if there are failures we should cap the score at 89.
Related Issues/PRs
Closes #7338