core(tap-targets): disable font size and tap targets audit on desktop #7393
Conversation
mattzeunert
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
mattzeunert
changed the title
| @@ -274,6 +274,15 @@ class TapTargets extends Audit { | |||
| * @return {Promise<LH.Audit.Product>} | |||
| */ | |||
| static async audit(artifacts, context) { | |||
| if (!artifacts.TestedAsMobileDevice) { | |||
| // Tap target sizes aren't important for desktop SEO, so disable the audit there. | |||
| // On desktop people also tend to have more precise pointing devices than fingers. | |||
There was a problem hiding this comment.
It might be an interesting exercise to try to find tap targets completely occluded by other elements at some point in the future 🤔
Doing a desktop run is already something the config allows users to do ( The alternative is we pass the complexity to the user and have them choose which audits are appropriate given their selected configuration. I think we'd agree that is less desirable. |
|
This kind of screw up is why I won't show Lighthouse to clients inquiring. If I have to explain your bugs for you and then show not one though two developers who think it's perfectly acceptable to run a mobile test for desktop then the entire test is invalid. That applies to all my clients for my web platform business. |
|
@jabcreations hmmmm.. you don't? The change here (from 5 years ago) made it so you don't need to worry about this. font-size and tap-target audits are only evaluated if it's a mobile run. if it's a desktop run then these two audits will be passing. From an SEO POV these checks are moot in desktop. |
|
A desktop device test with Lighthouse in Chrome 122.0: So yeah, either the change didn't work or someone has since then broken it. |
|
That image shows an internal error in Lighthouse when running that audit. If you hover over it, it'll tell us which artifact error'd. The audit only marks itself inapplicable for desktop runs if it makes it past the artifact verification stage (unfortunately). This is not related to this old PR, but if you open a new issue with reproduction steps we can look into it. Please keep in mind we have a code of conduct and your initial engagement with us is not adhering to it. |
|
for eng team: reproable on https://www.jabcreations.com/features/ 
and here's it in CDP: we're gonna drop this audit in exchange for axe, so this will get resolved via that. ✅ |
Summary
These two audits aren't important to desktop SEO, so we should disable them there.
Related Issues/PRs
Closes #6687