misc: simplifications in simulator/connection-pool #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
suggested changes
Apr 2, 2019
| const observedConnectionWasReused = !!this._connectionReusedByRequestId.get(record.requestId); | ||
| /** @type {TcpConnection[]} */ |
There was a problem hiding this comment.
this isn't necessary anymore?
There was a problem hiding this comment.
this isn't necessary anymore?
no, its inferred from the first part of the init and the _findAvailableConnectionWithLargestCongestionWindow callsite
| */ | ||
| _markNodeAsReadyToStart(node, queuedTime) { |
There was a problem hiding this comment.
I'd prefer to keep this, it's pretty helpful when stepping through the debugger
There was a problem hiding this comment.
I'd prefer to keep this, it's pretty helpful when stepping through the debugger
gotcha :)
patrickhulce
reviewed
Apr 2, 2019
| @@ -503,7 +501,7 @@ module.exports = Simulator; | |||
| * @typedef NodeTimingIntermediate | |||
| * @property {number} [startTime] | |||
| * @property {number} [endTime] | |||
| * @property {number} [queuedTime] | |||
| * @property {number} [queuedTime] Helpful for debugging. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another one I accumulated while stepping through the simulator. Feel free to reject anything @patrickhulce :)
remove
recordsfromLH.Artifacts.NetworkAnalysis. The caller of the computed artifact has to already have them to get theNetworkAnalysis, and we never use them on any instance of the type anyways.early return in
PageDependencyGraph.linkNetworkNodes()for the common case where there were no redirects of a particular recordsplit
ConnectionPool.acquire()into the case where a connection is needed to fetch a record and the case where a connection is already fetching a record.This seems ok as a place where the generality hasn't proven necessary...we only call
acquire()in three places, and the two done that return assigned connections already explicitly call out with a comment and a type cast that it knows a connection already exists for this record.removed
NodeTimingIntermediate.queuedTimeas it isn't used for anything. I can add back if this was useful for debugging or something.