-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCP is not friendly with 'carousel' hero image #61
Comments
Yeah, unfortunately carousel's are problematic for LCP, and this is something we're actively looking into making better. Right now we have an experimental implementation in Chrome 85 to not discard elements removed from the DOM, which should help most carousel cases, but we need to gather data on that first to make sure it doesn't have other unintended consequences. I know "we're working on it" probably isn't the most satisfying answer, but it is the reality of the current situation. For the perspective of this library, it's working as intended because it's just reporting what the underlying web API is reporting. And any changes we make to the web API to better handle carousel cases should not require any changes to this library. |
hi @philipwalton thanks for the reply, please let us know if there was an update to this issue. LCP is a very important metric since its part of web vitals which will be a ranking factor for SEO in the future, i really hope we won't be penalized for using a carousel because our users seem to love that feature :) For testing purposes you can visit our production site https://www.pogo.com/ |
The latest update is it's looking like our experimental implementation to not ignore removed DOM elements was successful and will land, so LCP should be much more carousel-friendly in the near future (most likely in Chrome 88). Since this issue doesn't require any changes to this library, I'm going to close this issue. |
Thanks! |
This is a follow up to #60
On our website (https://www.pogo.com) we have an auto-scrolling hero image, also referred to as a 'carousel' spotlight image. The behavior of this seems to cause a new entry into LCP each time it is changed out before any user interaction. This can lead to a confusing or erroneous LCP response if the page is not interacted with by the user before the first swap occurs.
![Screen Shot 2020-07-07 at 12 54 31 PM](https://user-images.githubusercontent.com/2840020/86842857-a2414e80-c05a-11ea-8b71-d86b9bf739a2.png)
Is there any guidance into using LCP with such behavior, or an alternative implementation?
The text was updated successfully, but these errors were encountered: