Url manipulation #1154
Merged
Url manipulation #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling a73c948 on url-manipulation into ** on v3**. |
jeffposnick
approved these changes
Jan 4, 2018
| } | ||
|
|
||
| let strippedUrl = _removeIgnoreUrlParams( | ||
| const noSearchUrl = _removeIgnoreUrlParams( |
There was a problem hiding this comment.
noSearchUrl sounds like it's completely dropping the search portion, which isn't the case. We're just removing the ignored search parameters. Could you name it urlWithoutIgnoredParams or something similar?
|
Changes Unknown when pulling 8f88fc9 on url-manipulation into ** on v3**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
This is a step towards closing #903 (although will add some docs once this PR is approved before closing it).
cleanUrls-> Name is to match firebase config, happy to change if something likeprettyUrlsis betterurlManipulation-> This is a function that allows developers to add any additional permutations of a URL that could be precached. I found this will be used, but serves as a helpful escape hatch for any further alterations developers need.