Address tab-related flakiness in integration tests #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
commented
Feb 13, 2021
| @@ -17,8 +17,7 @@ const windowLoaded = async () => { | |||
| await executeAsyncAndCatch(async (cb) => { | |||
| const loaded = () => { | |||
| if (!window.Workbox) { | |||
| const error = new Error('Workbox not yet loaded...'); | |||
| cb({error: error.stack}); | |||
| cb({error: `window.Workbox is undefined; location is ${location.href}`}); | |||
There was a problem hiding this comment.
This is what helped me realize that when the workbox-window tests were failing, it was because a tab navigated to the workbox-broadcast-update URL had the focus...
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
I did a little digging, and I think this change fixes #2321, which was caused by a leftover tab from the
workbox-broadcast-updatetest sometimes getting the focus in the middle of theworkbox-windowtest suite. This adds a bit of structure around how tabs are opened and closed to hopefully prevent that.That being said, the
workbox-windowintegration test for externally triggered registrations is still skipped in Safari, because it just doesn't work. I tried doing the same process manually, and at that point, it follows the steps that should be covered in test, so I don't know if it's just a timing issue, or if there's something off about the webdriver environment with regard to service worker registrations in other Safari tabs.In any case, I hope this PR is a still towards a bit less flakiness.