Skip to content

Commit

Permalink
(bugfix) Fix deploy for network-aware only-if-cached asset paths
Browse files Browse the repository at this point in the history
  • Loading branch information
addyosmani committed Aug 28, 2019
1 parent 91428e2 commit 8b8683a
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1,316 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const MEDIA_TYPE = {
IMAGE: 'image'
};

const ResponsiveMedia = ({mediaType, objectURL}) => {
const ResponsiveMedia = ({ mediaType, objectURL }) => {
let responsiveMedia = null;

if (mediaType === MEDIA_TYPE.VIDEO) {
Expand All @@ -40,19 +40,19 @@ const requestMedia = async ect => {
let baseURL;
switch (ect) {
case 'slow-2g':
baseURL = '/assets/responsive-media/image-min-res.jpg';
baseURL = 'assets/responsive-media/image-min-res.jpg';
break;
case '2g':
baseURL = '/assets/responsive-media/image-medium-res.jpg';
baseURL = 'assets/responsive-media/image-medium-res.jpg';
break;
case '3g':
baseURL = '/assets/responsive-media/image-max-res.jpg';
baseURL = 'assets/responsive-media/image-max-res.jpg';
break;
case '4g':
baseURL = '/assets/responsive-media/video-hd-res.mp4';
baseURL = 'assets/responsive-media/video-hd-res.mp4';
break;
default:
baseURL = '/assets/responsive-media/video-hd-res.mp4';
baseURL = 'assets/responsive-media/video-hd-res.mp4';
break;
}

Expand Down Expand Up @@ -86,7 +86,7 @@ const requestMedia = async ect => {
console.log('only-if-cached feeding url => ', url);
return <ResponsiveMedia mediaType={mediaType} objectURL={objectURL} />;
}
} catch(error) {
} catch (error) {
console.log('[ConnectionAwareMedia requestImage only-if-cached] error => ', error);
}
}
Expand All @@ -98,7 +98,7 @@ const requestMedia = async ect => {
const objectURL = URL.createObjectURL(blob);
console.log('network request feeding url => ', baseURL);
return <ResponsiveMedia mediaType={mediaType} objectURL={objectURL} />;
} catch(error) {
} catch (error) {
console.log('[ConnectionAwareMedia requestImage default] error => ', error);
}

Expand Down

0 comments on commit 8b8683a

Please sign in to comment.