Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Incorporate network-aware code-splitting into Shrine #6

Closed
addyosmani opened this issue Jul 11, 2019 · 0 comments
Closed

[React] Incorporate network-aware code-splitting into Shrine #6

addyosmani opened this issue Jul 11, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@addyosmani
Copy link
Collaborator

addyosmani commented Jul 11, 2019

The originally React Shrine application implemented code-splitting for a number of views. We could augment the implementation there to use network-aware code-splitting such that:

  • For a product page, a user is displayed an item with an image
  • If you're on a slow-connection you are shown just an image with the ability to view it. We only load the smallest version of this component possible.
  • If you're on a fast-connection, we conditionally load a version of the product image with react-magnifier support. This allows the user to get an enhanced experience. Basically, they can magnify the image to view more details on it.

Assigned to Anton

@addyosmani addyosmani added the bug Something isn't working label Jul 11, 2019
addyosmani added a commit that referenced this issue Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant