Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Updating the adaptive-loading demos to use the new package of hooks #93

Closed
anton-karlovskiy opened this issue Nov 15, 2019 · 2 comments
Closed

[Update] Updating the adaptive-loading demos to use the new package of hooks #93

anton-karlovskiy opened this issue Nov 15, 2019 · 2 comments

Comments

@anton-karlovskiy
Copy link
Contributor

anton-karlovskiy commented Nov 15, 2019 •
edited

A new task high up in priority is a PR that updates the adaptive-loading demos to use the new package of hooks from npm (where possible)
@anton-karlovskiy
Copy link
Contributor Author

@addyosmani

I think battery hook is missing from react-adaptive-hooks. Is it on purpose?

@addyosmani
Copy link
Collaborator

Yeah, we dropped it as Battery Status API is likely going away. I think we can continue using a custom hook in this repo for it during the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addyosmani @anton-karlovskiy