Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play nice with DevTools overrides #17

Closed
mathiasbynens opened this issue Oct 7, 2019 · 1 comment
Closed

Play nice with DevTools overrides #17

mathiasbynens opened this issue Oct 7, 2019 · 1 comment

Comments

@mathiasbynens
Copy link
Member

DevTools supports emulating prefers-color-scheme. It would be great if dark-mode-toggle could play nice with this functionality. Some discussion: v8/v8.dev#254 (comment) + the workaround @RReverser used to make this work for v8.dev: v8/v8.dev@8ab0b70
@tomayac
Copy link
Member

tomayac commented Oct 22, 2019

This has been addressed with ac48837, and the behavior now is now the one you forced through the (to be removed) work-around. Thanks for filing this issue.

@tomayac tomayac closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathiasbynens @tomayac