You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.
@jeffposnick This change also changed the output from KB (1024 bytes) to kB (1000 bytes), which is inconsistent with how Chrome's network tab displays file sizes (as well as how ls usually displays file sizes). Since Chrome displays the size in KB, I think having the tool output sizes in kB can be confusing. I can understand generally wanting to use npm packages instead of hand-rolled functions, but in this case the function was pretty simple and I think replacing it with pretty-bytes was actually a downgrade due to the KB/kB mismatch.
Is there any chance you'd be open to a PR reverting f201914, or is that outside the scope of maintenance for this repository (given that it's kind of deprecated by workbox)?
@sindresorhus's https://github.com/sindresorhus/pretty-bytes can replace the function at https://github.com/jeffposnick/sw-precache/blob/00c2b0bc7ab785cae7446b3a166e83435c644f02/sw-precache.js#L43-L53
The text was updated successfully, but these errors were encountered: