Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete doesn't remove all generations #50

Closed
maroux opened this issue Jul 29, 2019 · 1 comment · Fixed by #51
Closed

Delete doesn't remove all generations #50

maroux opened this issue Jul 29, 2019 · 1 comment · Fixed by #51

Comments

@maroux
Copy link
Contributor

maroux commented Jul 29, 2019

(I'm working on the fix)
@maroux
Copy link
Contributor Author

maroux commented Jul 29, 2019

The command delete not deleting all versions if fine, since you may accidentally delete and may want to recover. However, there should be a lifecycle rule that deletes old versions of deleted objects automatically.

maroux added a commit to maroux/berglas that referenced this issue Jul 29, 2019
@maroux
Allow permanent deletion of secrets
e49501c 
Also fixes unrelated issue - list shouldn't return generations of (non-permanently)
deleted secrets.

Fixes GoogleCloudPlatform#50
@maroux maroux mentioned this issue Jul 29, 2019
Merged
maroux added a commit to maroux/berglas that referenced this issue Jul 31, 2019
@maroux
Allow permanent deletion of secrets
50253dd 
Also fixes unrelated issue - list shouldn't return generations of (non-permanently)
deleted secrets.

Fixes GoogleCloudPlatform#50
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow permanent deletion of secrets maroux/berglas
1 participant
@maroux