Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Swapper: terraform-google- requirement #2065

Closed
apeabody opened this issue Dec 27, 2023 · 3 comments
Closed

Module Swapper: terraform-google- requirement #2065

apeabody opened this issue Dec 27, 2023 · 3 comments
Labels
bug Something isn't working triaged

Comments

@apeabody
Copy link
Collaborator

apeabody commented Dec 27, 2023

A few repos don't use the terraform-google- prefix. E.g. terraform-dynamic-python-webapp, terraform-large-data-sharing-java-webapp

Expected to find repo name prefixed with terraform-google-. Got: terraform-dynamic-python-webapp

Expected to find repo name prefixed with terraform-google-. Got: terraform-large-data-sharing-java-webapp

return "", "", fmt.Errorf("expected to find repo name prefixed with terraform-google-. Got: %s", repoName)

@apeabody apeabody added bug Something isn't working triaged labels Dec 27, 2023
@apeabody
Copy link
Collaborator Author

FYI @bharathkkb

@bharathkkb
Copy link
Member

Hey @apeabody, I think this should now be fixed with #2056 downgrading this from an error- released in #2059 and in the latest 1.18x dev tools image. I retried the lint run in that repo and it passed

@apeabody
Copy link
Collaborator Author

Great! Yup, a run with dev-tools 1.18.4 looks good! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

2 participants