Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

Missing self in flowers adaptive_wait method #15

Closed
maysamemadi opened this issue Feb 5, 2017 · 2 comments
Closed

Missing self in flowers adaptive_wait method #15

maysamemadi opened this issue Feb 5, 2017 · 2 comments

Comments

@maysamemadi
Copy link

Looks like there is a small error in the flowers example pipeline module. I know you currently don't accept contributions, so I'll just point it out here.

The prediction attempt called from the adaptive_wait method as part of deploy_model is missing a self. As a result, after successful deployment of the model, prediction attempts will quietly fail until max wait time is exceeded. Changing that line to self.predict(self.args.sample_image_uri) should fix it.

@joshgc
Copy link
Contributor

joshgc commented Feb 6, 2017

Thanks for the heads up, we will get this rolled into the next release

@joshgc
Copy link
Contributor

joshgc commented Feb 6, 2017

Just committed the code, so I'll close the issue, but please let me know about anything else you find!

@joshgc joshgc closed this as completed Feb 6, 2017
nat-henderson pushed a commit to nat-henderson/cloudml-demo that referenced this issue Mar 20, 2018
gogasca pushed a commit that referenced this issue Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants