Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow validation doesn't catch syntax error in 'Name' field in SubWorkflow #416

Closed
helen-fornazier opened this issue May 18, 2018 · 2 comments

Comments

@helen-fornazier
Copy link
Contributor

If a workflow has an invalid name, e.g. img-test_independent, executing this workflow fails as expected:

[Daisy] Running workflow "img-test_independent" (id=zy2s1)

[Daisy] Errors in one or more workflows:
  img-test_independent: error validating workflow: workflow field 'Name' must start with a letter and only contain letters, numbers, and hyphens

But if we use this bad Workflow in a IncludeWorflow or SubWorkflow, validation doesn't fail.

@adjackura
Copy link
Contributor

For IncludeWorkflow and SubWorkflow the name is overwritten with the step name, so the invalid name is never used.

@adjackura
Copy link
Contributor

I'm going to close this as the name fields are ignored (along with most top level fields) for subworkflow and include workflows.

gaohannk pushed a commit to gaohannk/compute-image-tools that referenced this issue May 20, 2021
…g-plank

Mount kubeconfig secret for hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants