New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded region and location #47

Closed

dinigo opened this issue Mar 2, 2023 · 3 comments

dinigo commented Mar 2, 2023

Location and region is hardcoded over and over in the terraform config.

This makes it difficult to extract the location/region to be abale to easily localise the deployment

Location/Region MUST be configurable from the outside

Collaborator

AdamPaternostro commented Apr 6, 2023

Some of this is due to preview features and only being in certain regions. I will have a preview region for these services.

Collaborator

AdamPaternostro commented Apr 8, 2023

This has been corrected: https://github.com/GoogleCloudPlatform/data-analytics-golden-demo/blob/main/terraform/tf-variables.tf#L103-L266

AdamPaternostro closed this as completed

Collaborator

AdamPaternostro commented Apr 18, 2023

Please see this for an EU deployment (this has been tested) https://github.com/GoogleCloudPlatform/data-analytics-golden-demo/blob/main/deploy-europe-region.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment