Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples for k8s are wrong #41

Closed
FranOis opened this issue Nov 29, 2017 · 2 comments
Closed

Examples for k8s are wrong #41

FranOis opened this issue Nov 29, 2017 · 2 comments

Comments

@FranOis
Copy link

FranOis commented Nov 29, 2017

Various example yaml does not reflect the right way to setup on k8s.

One such example is the args for this file https://github.com/GoogleCloudPlatform/endpoints-samples/blob/master/k8s/esp_echo_http.yaml

It is the same thing on the google documentation on cloud endpoints, arguments passed should be -p -a -s -v etc.

Link to the google documentation that does not comply with the code in ESP: https://cloud.google.com/endpoints/docs/openapi/get-started-kubernetes

@kryzthov
Copy link
Contributor

Hello,

To the best of my knowledge, the arguments described in the example and in the documentation are in agreement with the code in ESP: see the argument declarations here https://github.com/cloudendpoints/endpoints-tools/blob/master/start_esp/start_esp.py#L396-L565

Are you saying that the command-lines in the examples and in the documentation are not working?
Thanks!

@FranOis
Copy link
Author

FranOis commented Nov 30, 2017

Derp... Looks like I was constantly using dashes instead of underscore. Sorry about that.

@FranOis FranOis closed this as completed Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants