Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting-started/bookshelf/pubsub_worker does not implement health check handler #10

Closed
wuman opened this issue Feb 2, 2016 · 2 comments
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@wuman
Copy link
Contributor

wuman commented Feb 2, 2016

The pubsub_worker module in the bookshelf sample does not seem to implement a health check handler like the default module. Is this an oversight or are worker modules not supposed to implement a health check handler?

@broady
Copy link
Contributor

broady commented Feb 8, 2016

Worker modules have no technical difference to regular modules.

The worker module actually responds to requests on /_ah/health with the regular handler (that responds with the number of books processed). That constitutes a healthy request.

I think it'd be better to just use appengine.Main(), though.

@tbpg
Copy link
Contributor

tbpg commented Jun 11, 2019

It's been a few years and an update for Bookshelf is in the works. Closing this.

@tbpg tbpg closed this as completed Jun 11, 2019
@tbpg tbpg self-assigned this Jun 11, 2019
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

4 participants