Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: flaky test, bad error message #104

Closed
broady opened this issue Sep 2, 2016 · 4 comments
Closed

pubsub: flaky test, bad error message #104

broady opened this issue Sep 2, 2016 · 4 comments
Assignees
@rakyll
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@broady
Copy link
Contributor

broady commented Sep 2, 2016 

main_test.go:59: got [0xc8204e2440 0xc8204e2460]; want the list with topic = "golang-samples-topic-example""
@broady
Copy link
Contributor Author

broady commented Sep 2, 2016 

main_test.go:94: got []; want a list with subscription "golang-samples-subscription"

@rakyll
Copy link
Contributor

rakyll commented Sep 6, 2016

What is running against this project test account's pubsub?

We probably need isolation of names for these tests. I am not thinking of any other issue why they are flaky.

@broady
Copy link
Contributor Author

broady commented Sep 6, 2016

Just these tests. But they might run concurrently.

@rakyll
Copy link
Contributor

rakyll commented Sep 7, 2016

I will try to namespace everything and delete stuff I create only in the lifecycle of these tests.

rakyll added a commit that referenced this issue Sep 7, 2016
@rakyll
pubsub: fix the race in tests
a1a5121 
Fixes #104.
@rakyll rakyll mentioned this issue Sep 7, 2016
Closed
broady added a commit that referenced this issue Sep 9, 2016
@broady
pubsub/subscriptions: make list less flaky
7b0a708 
Updates #104.
@broady broady mentioned this issue Sep 9, 2016
Merged
@broady broady closed this as completed Nov 25, 2016
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakyll rakyll

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@broady @rakyll @yoshi-automation