Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appengine_flexible: Cloud SQL and Datastore samples should only store first two Octets of IP #9

Closed
lesv opened this issue Jan 29, 2016 · 4 comments · Fixed by #1012
Closed

appengine_flexible: Cloud SQL and Datastore samples should only store first two Octets of IP #9

lesv opened this issue Jan 29, 2016 · 4 comments · Fixed by #1012
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: enhancement

Comments

@lesv
Copy link

lesv commented Jan 29, 2016

Principle of least required data retention.
@broady broady changed the title Cloud SQL and Datastore samples should only store first two Octets of IP getting-started/bookshelf: Cloud SQL and Datastore samples should only store first two Octets of IP Jan 29, 2016
@broady
Copy link
Contributor

broady commented Jan 29, 2016

Perhaps there's something more interesting we can store.

@broady broady changed the title getting-started/bookshelf: Cloud SQL and Datastore samples should only store first two Octets of IP docs/managed_vms: Cloud SQL and Datastore samples should only store first two Octets of IP Mar 31, 2016
@jabubake
Copy link
Contributor

jabubake commented Apr 3, 2018

@kurtisvg @ryanmats FYI

@tbpg
Copy link
Contributor

tbpg commented Jun 11, 2019

I looked around but didn't see which sample this was referring to (and didn't find relevant mentions of IP). Closing as obsolete (sample moved/changed?)

@tbpg tbpg closed this as completed Jun 11, 2019
@tbpg tbpg reopened this Jun 11, 2019
@tbpg
Copy link
Contributor

tbpg commented Jun 11, 2019

One example: https://github.com/GoogleCloudPlatform/golang-samples/blob/master/appengine_flexible/cloudsql/cloudsql.go#L98-L102

@tbpg tbpg changed the title docs/managed_vms: Cloud SQL and Datastore samples should only store first two Octets of IP docs/appengine_flexible: Cloud SQL and Datastore samples should only store first two Octets of IP Jun 11, 2019
@tbpg tbpg changed the title docs/appengine_flexible: Cloud SQL and Datastore samples should only store first two Octets of IP appengine_flexible: Cloud SQL and Datastore samples should only store first two Octets of IP Jun 11, 2019
@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 3, 2019
@tbpg tbpg added priority: p2 Moderately-important priority. Fix may not be included in next release. type: enhancement and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Oct 3, 2019
@tbpg tbpg mentioned this issue Oct 9, 2019
Merged
@tbpg tbpg closed this as completed in #1012 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: enhancement
Projects
None yet
Milestone
No milestone
5 participants
@broady @JustinBeckwith @lesv @jabubake @tbpg