logging-bunyan: HttpRequest support #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the bunyan provided metadata includes a httpRequest property, format that as the HttpRequest message. This allows Stackdriver logging to format request logs nicely. Fixes: googleapis#2251
googlebot
added
the
cla: yes
packages/logging-bunyan/README.md
Outdated
| @@ -66,7 +66,29 @@ var loggingBunyan = require('@google-cloud/logging-bunyan')({ | |||
| // ...you're good to go! | |||
| ``` | |||
|
|
|||
| ## Formatting Request Logs | |||
|
|
|||
| To format your request logs you can provide a `httpRequest` property on the bunyan metadata you provide along with the log message. We will format this as the [`HttpRequest`][http-request-message] message and Stackdriver logging will show this as a request log. Example: | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
CI is green now. PTAL. |
|
Cool, thanks! |
ofrobots
added a commit
to ofrobots/google-cloud-node
that referenced
this pull request
May 25, 2017
If the winston provided metadata includes a httpRequest property, format that as the HttpRequest message. This allows Stackdriver logging to format request logs nicely. Ref: googleapis#2325
ofrobots
added a commit
to ofrobots/google-cloud-node
that referenced
this pull request
May 25, 2017
If the winston provided metadata includes a httpRequest property, format that as the HttpRequest message. This allows Stackdriver logging to format request logs nicely. Ref: googleapis#2325
|
thanks so much for this update! is there a release planned soon so i can give it a shot? |
This was referenced Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bunyan provided metadata includes a httpRequest property, format
that as the HttpRequest message. This allows Stackdriver logging to
format request logs nicely.
Fixes: #2251
EDIT: note that this is semver-major.