Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where do we put tests that use jetty, but not jetty-runtime? #38

Closed
joakime opened this issue Sep 15, 2016 · 4 comments
Closed

Where do we put tests that use jetty, but not jetty-runtime? #38

joakime opened this issue Sep 15, 2016 · 4 comments

Comments

@joakime
Copy link
Contributor

joakime commented Sep 15, 2016

There's a few scenarios where Jetty is in use, but wouldn't use the jetty-runtime (or jetty-distribution) to execute.

A few common examples:

  • Solr
  • Spring-Boot
  • Dropwizard
@joakime
Copy link
Contributor Author

joakime commented Sep 15, 2016

You could add jetty booted via an OSGi container as another example

@gregw
Copy link
Contributor

gregw commented Sep 15, 2016

I don't think we need to test jetty per-se in these scenarios. We just need to test the capabilities of the runtime. So in this case such applications would likely be based on the openjdk-runtime. We need tests at that level to check the capabilities the runtime provides: JRE, logging, cloud debugger, memcache, etc.

Having some 3rd party sample jars to test would not hurt either.

@joakime
Copy link
Contributor Author

joakime commented Sep 15, 2016

for low hanging fruit, Solr is an easy one then.

its pretty much an unpack, configure, and run setup.

@meltsufin
Copy link
Member

I'm with @gregw that jetty-specific tests should not be in this repo. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants