Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Installation instructions end up using an old build of metacontroller #67

Closed
nikhilk opened this issue Jul 17, 2018 · 2 comments
Closed

Comments

@nikhilk
Copy link

nikhilk commented Jul 17, 2018

The installation documentation references the manifest file which references an older docker image.

https://github.com/GoogleCloudPlatform/metacontroller/blob/master/manifests/metacontroller.yaml#L66

References metacontroller/metacontroller:0.2. Should it reference latest?

@enisoc
Copy link

enisoc commented Jul 17, 2018

The intention is to encourage people to use a pinned version tag when they deploy it, so they have control over when to update to new versions. Sometimes it does make sense to use latest, like when doing testing or active development. In that case, I recommend using something like this to override the tag:

https://metacontroller.app/contrib/build/#skaffold-build

@nikhilk
Copy link
Author

nikhilk commented Jul 18, 2018

Generally agree with being explicit rather than relying on how latest is resolved when deploying.

I thought I saw behavior where 0.2 was different than what was documented, hence I thought I'd capture this here, but I think it was due to my user error (as discussed offline).

So I'll go ahead and close this out.

@nikhilk nikhilk closed this as completed Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants