Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

currencyservice - unable to access external endpoint with istio #80

Closed
mukundha opened this issue Oct 16, 2018 · 3 comments
Closed

currencyservice - unable to access external endpoint with istio #80

mukundha opened this issue Oct 16, 2018 · 3 comments
Labels
area/istio what/bug

Comments

@mukundha
Copy link

Currency service uses this endpoint - http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml

Maybe this could be recent change to the endpoint, but it redirect to a https URL,
so if we enable Istio, we run into the issue described here

there are 2 options

  1. Open all egress traffic [diasble istio introspection]
  2. maybe find another alternative or host a http equivalent of this endpoint?

Thanks,
@ahmetb ahmetb changed the title currencyservice - unable to access external endpoint currencyservice - unable to access external endpoint with istio Oct 16, 2018
@ahmetb
Copy link
Contributor

ahmetb commented Oct 16, 2018

Indeed, the change now poses a problem.

Another good option is to actually hardcode the conversion rates. We only use a few of them anyway. If you have time to refactor the currencyservice to use hardcoded conversion rates, it would be much appreciated.

mukundha added a commit to mukundha/microservices-demo that referenced this issue Oct 17, 2018
@mukundha
Fix for the issue: GoogleCloudPlatform#80
2283bd2 
Updated server.js to use Env variable, instead of hardcoded currency URL
Hosting a currency service, that is serving via http
updated the manifests to include the env and egress whitelisting
@mukundha mukundha mentioned this issue Oct 17, 2018
Closed
@ahmetb
Copy link
Contributor

ahmetb commented Oct 18, 2018

cc: @ace-n also, #82.
We might need to hardcode the currency conversion values into the service. This has a potential of breaking live on-stage demos since we don't control it.

@ahmetb ahmetb mentioned this issue Feb 6, 2019
Closed
@ahmetb
Copy link
Contributor

ahmetb commented Mar 7, 2019

We removed the external dependency, so this should now be obsolete.

@ahmetb ahmetb closed this as completed Mar 7, 2019
tjohander-splunk pushed a commit to tjohander-splunk/microservices-demo-google that referenced this issue Dec 17, 2022
@rmfitzpatrick
update deps to address cves (GoogleCloudPlatform#80)
0d24a1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/istio what/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmetb @mukundha