New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable travis and coveralls #8

Closed

tmatsuo opened this issue May 8, 2015 · 3 comments

Assignees

Labels

Contributor

tmatsuo commented May 8, 2015

After merging #6

tmatsuo self-assigned this

Contributor Author

tmatsuo commented May 14, 2015

weird, the build for the PR succeeded
https://travis-ci.org/GoogleCloudPlatform/python-docs-samples/builds/61875739

but the build for merge failed
https://travis-ci.org/GoogleCloudPlatform/python-docs-samples/builds/62574554

Those should have the same results.

Contributor Author

tmatsuo commented May 14, 2015

suspecting it's because tox 2.0 started to filter env variables
https://testrun.org/tox/latest/example/basic.html#passing-down-environment-variables

Contributor Author

tmatsuo commented May 15, 2015

Fixed by #15

tmatsuo closed this as completed

yoshi-automation added 🚨 triage me labels

nicain added a commit that referenced this issue


          Merge pull request #8 from nicain/sasha-gitg-patch-3

a44ee49

Update embedding.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment