Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud API Client initialization inconsistent #52

Closed
frankyn opened this issue Sep 16, 2016 · 1 comment
Closed

Google Cloud API Client initialization inconsistent #52

frankyn opened this issue Sep 16, 2016 · 1 comment
Labels
duplicate 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@frankyn
Copy link
Member

frankyn commented Sep 16, 2016

Story

Rubyist knows to use Google Data Store API. Rubyist wants to learn Google Vision API and the samples use different Google Cloud API Client initialization. Confusion begins.

Issue
Initialization is inconsistent between these two samples. The issue may exist in other samples within the Ruby space.

DataStore uses
require "gcloud"
gcloud = Gcloud.new
datastore = gcloud.datastore

Vision uses
require "google/cloud"
gcloud = Google::Cloud.new
vision = gcloud.vision

Issue exists in the following locations:
appengine/datastore/app.rb
appengine/pubsub/app.rb
appengine/pubsub/spec/pubsub_spec.rb
bigquery/shakespeare.rb
datastore/sample.rb
logging/spec/sample_spec.rb
logging/sample.rb
pubsub/sample.rb

Possible Solution
Use the same initialization in all Ruby samples.

@frankyn frankyn self-assigned this Sep 22, 2016
frankyn added a commit that referenced this issue Sep 22, 2016
frankyn added a commit that referenced this issue Sep 22, 2016
@frankyn frankyn removed their assignment Sep 26, 2016
@beccasaurus
Copy link
Contributor

Duplicate of #55

Fix pending in #65

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants