Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the accessibility of the example #158

Open
felixzapata opened this issue Apr 20, 2019 · 0 comments · May be fixed by #159
Open

Improve the accessibility of the example #158

felixzapata opened this issue Apr 20, 2019 · 0 comments · May be fixed by #159
Assignees
@petele
Labels
enhancement

Comments

@felixzapata
Copy link
Contributor

Some accessibility issues to fix:

  • HTML more semantic in order to represent the information. For example, my opinion is the future weather should be a table, and the information of the current day should have a definition list.
  • Hide the dialog if is not visible.
  • Use alternate texts for the icons.
@felixzapata felixzapata linked a pull request Apr 20, 2019 that will close this issue
Open
@petele petele self-assigned this Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petele petele

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(a11y): improve the a11y of the example felixzapata/your-first-pwapp
2 participants
@petele @felixzapata