Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more suggestions for various build failures. #27

Closed
3 of 5 tasks
coollog opened this issue Jan 29, 2018 · 3 comments
Closed
3 of 5 tasks

Add more suggestions for various build failures. #27

coollog opened this issue Jan 29, 2018 · 3 comments

Comments

@coollog
Copy link
Contributor

coollog commented Jan 29, 2018

When running mvn jib:build, there are various failures caught in the BuildImageMojo#buildImage method. These catches provide extra feedback to the user to help them understand the issue and provide suggestions for how to fix the issue.

The actionables are to:

  1. Figure out what other build failures there are, if any (compile a list and maybe add that below)
  2. Add similar handling for these build failures.
  3. (Maybe improve how these failures are handled currently)

Build failures to handle:

@coollog
Copy link
Contributor Author

coollog commented Mar 22, 2018

@TadCordle Do you want to take a stab at this? This could get you acclimated to various codepaths Jib takes and understand the user experience (and improve it).

@TadCordle TadCordle self-assigned this Mar 22, 2018
@coollog coollog modified the milestones: 0.2.0, 0.1.7 Mar 22, 2018
@coollog
Copy link
Contributor Author

coollog commented Mar 23, 2018

Another thing I saw was if for example, the user does not define a credHelper, but Jib tried to use the Docker config for credentials, but the credentials in there were for a different GCP project than the project you want to push to, the build fails with no suggestions. We might want to explore providing better feedback in these cases where we have the same registry but the credentials retrieved are not correct.

@TadCordle
Copy link
Contributor

I haven't been able to reproduce that one yet, but I opened an issue for it - #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants