Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HEALTHCHECK command #17

Closed
priyawadhwa opened this issue Feb 15, 2018 · 5 comments
Closed

Implement HEALTHCHECK command #17

priyawadhwa opened this issue Feb 15, 2018 · 5 comments
Projects

Comments

@priyawadhwa
Copy link
Collaborator

See #1 for details

@priyawadhwa priyawadhwa added this to To do in alpha via automation Feb 15, 2018
@dlorenc dlorenc added the good first issue Good for newcomers label Apr 27, 2018
@chrisz100
Copy link
Contributor

Healthcheck requires a different config struct:
https://github.com/moby/moby/blob/master/api/types/container/config.go

It seems to be not included in the open container specs - thus implementing this would require completely replacing the base for configs.

After that - if I get the code right - it would simply mean passing the already prepared HealthConfig struct to the config to persist it. Which shouldn't be hard at all - but that requires HealthCheck to be existent in the container config.

Ideas?

@chrisz100
Copy link
Contributor

@dlorenc @priyawadhwa any idea?

@priyawadhwa
Copy link
Collaborator Author

Hey, sorry for the late response! We use the go-containerregistry library for working with our images, and right now the config doesn't have a field for Healthcheck. You'd probably have to create the healthcheck config struct in go-containerregistry and add it to the config before starting to implement this command in kaniko.

@chrisz100
Copy link
Contributor

So you suggest contributing to go-containerregistry and using the merged version for proceeding here, correct?

@dlorenc
Copy link
Collaborator

dlorenc commented May 14, 2018

@chrisz100 correct! I can help you get that PR merged into go-containerregistry as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
alpha
  
Done
Development

No branches or pull requests

3 participants